This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
add feature wasmtime-jitdump #9871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crystalin
reviewed
Sep 27, 2021
bkchr
suggested changes
Sep 27, 2021
pepyakin
reviewed
Sep 28, 2021
There was a problem hiding this comment.
There are a couple of notes:
- I am all for for the profiler. The jitdump profiler is not that heavy to my knowledge and should not be a problematic to be built by default.
- I am however not entirely sure about the way it is activated. The configuration IMO should not take place in ad-hoc places like deep in a crate. It should come from the CLI crate (or whatever place is more appropriate in the setting in question). However, I do not intend to block this PR because of that — I realize it is important for the stuff we are doing and block won't be productive.
- I am not entirely sure that setting some other value should lead to an error. I would prefer to ignore such a value, ideally printing a single warning message. That is not blocking as well.
Co-authored-by: Sergei Shulepov <s.pepyakin@gmail.com>
|
@pepyakin i'm applied 1. and 3. :) |
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
bkchr
added
A0-please_review
bkchr
added
the
D3-trivial 🧸
Conflicts: client/executor/wasmtime/Cargo.toml
ordian
added a commit
that referenced
this pull request
Oct 2, 2021
* master: (67 commits) Downstream `node-template` pull (#9915) Implement core::fmt::Debug for BoundedVec (#9914) Quickly skip invalid transactions during block authorship. (#9789) Add SS58 prefix for Automata (#9805) Clean up sc-peerset (#9806) Test each benchmark case in own #[test] (#9860) Add build with docker section to README (#9792) Simple Trait to Inspect Metadata (#9893) Pallet Assets: Create new asset classes from genesis config (#9742) doc: subkey usage (#9905) Silence alert about large-statement-fetcher (#9882) Fix democracy on-initialize weight (#9890) Fix basic authorship flaky test (#9906) contracts: Add event field names (#9896) subkey readme update on install (#9900) add feature wasmtime-jitdump (#9871) Return `target_hash` for finality_target instead of an Option (#9867) Update wasmtime to 0.29.0 (#9552) Less sleeps (#9848) remove unidiomatic (#9895) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose wasmtime optional feature jitdump to be able to profile wasm execution with perf.